Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React Riot hackathon #9861

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Add React Riot hackathon #9861

merged 1 commit into from
Jun 9, 2017

Conversation

sakinac
Copy link
Contributor

@sakinac sakinac commented Jun 6, 2017

React Riot is the first online worldwide hackathon for React! No cost to enter and teams can win some cool prizes. It's a community event to build the best React app in 48 hours.

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Format your code with prettier (npm run prettier).
  7. Run the Flow typechecks (npm run flow).
  8. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
  9. If you haven't already, complete the CLA.

React Riot is the first online worldwide hackathon for React! No cost to enter and teams can win some cool prizes. It's a community event to build the best React app in 48 hours.
@nhunzaker
Copy link
Contributor

Awesome. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Jun 9, 2017

Sorry I didn't chime in before. I'm not sure about this one—it's not a conference, but the page is specifically for conferences.

If we merge this hackathon, then everybody doing React hackathons will send PRs, and the conferences will drown in the list. Could you please revert?

(The hackathon itself looks great! Just probably not fitting for this page.)

@nhunzaker
Copy link
Contributor

No problem at all! That's good to know. I'll send up a revert commit.

nhunzaker added a commit that referenced this pull request Jun 9, 2017
@nhunzaker
Copy link
Contributor

Done in cd7ee0f. @sakinac I apologize for the confusion.

@gaearon
Copy link
Collaborator

gaearon commented Jun 9, 2017

No worries—sorry I didn’t catch it earlier. I meant to comment and forgot.
I hope this doesn’t discourage you from merging other PRs.

@sakinac Sorry about the confusion too! Maybe in the future we’ll have a more appropriate page for this, and we can put it there.

@sakinac
Copy link
Contributor Author

sakinac commented Jun 13, 2017

Ok thanks anyways. Hoping for another page soon where these things could be listed! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants