Fix parsing of use_file
#2146
Merged
Fix parsing of use_file
#2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the `use_file` parser definition is recursive, we were applying the operator swapping mappers more than once in the cases where the rule recursed. Instead, we should only apply the mapper to the final result of parsing the `use_file` rule. Fixes reasonml#1965 Fixes reasonml#1980
|
Thank you as always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
use_fileparser definition is recursive, we were applyingthe operator swapping mappers more than once in the cases where the rule
recursed.
Instead, we should only apply the mapper to the final result of parsing
the
use_filerule.Fixes #1965
Fixes #1980
Fixes #1970