Enable google-explicit-constructor (shared/oatmeal)

Summary: Enable clang-tidy checks for explicit single-parameter constructors. Reviewed By: amnn Differential Revision: D20283559 fbshipit-source-id: a2ef7091116e437a0d04360c66aa2004e2650f0e
facebook · Mar 13, 2020 · 261465e · 261465e
1 parent a6a335f
commit 261465e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/shared/QuickData.h b/shared/QuickData.h
@@ -44,7 +44,7 @@ class QuickData {
 
  public:
   // Read Mode
-  QuickData(const char* location);
+  explicit QuickData(const char* location);
 
   // Write Mode
   QuickData() = default;

diff --git a/tools/oatmeal/memory-accounter.cpp b/tools/oatmeal/memory-accounter.cpp
@@ -46,7 +46,7 @@ class MemoryAccounterImpl : public MemoryAccounter {
   UNCOPYABLE(MemoryAccounterImpl);
   MOVABLE(MemoryAccounterImpl);
 
-  MemoryAccounterImpl(ConstBuffer buf) : buf_(buf) {
+  explicit MemoryAccounterImpl(ConstBuffer buf) : buf_(buf) {
     // mark end to avoid special case in print.
     consumed_ranges_.emplace_back(buf_.len, buf_.len);
   }
@@ -139,7 +139,9 @@ class MultiBufferMemoryAccounter : public MemoryAccounter {
   MOVABLE(MultiBufferMemoryAccounter);
   UNCOPYABLE(MultiBufferMemoryAccounter);
 
-  MultiBufferMemoryAccounter(ConstBuffer buf) { accounters_.emplace_back(buf); }
+  explicit MultiBufferMemoryAccounter(ConstBuffer buf) {
+    accounters_.emplace_back(buf);
+  }
 
   void print() override;