Reset rather than delete sent field on next #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete was causing deoptimization due to backing class change and was unnecessary as this field was explicitly initialized to undefined and was not being checked for existence as best I can tell. When combined with facebook#207 saw a 40x throughput improvement under FF, from 39k operations/sec to 1.6M ops/src on http://kpdecker.github.io/six-speed/
|
Similarly, under Chrome the execution went from 39k ops/sec to 674k ops/sec. |
benjamn
added a commit
that referenced
this pull request
Jun 25, 2015
Reset rather than delete sent field on next.
|
Thanks a ton! That speedup is impressive. |
benjamn
added a commit
to benjamn/babel
that referenced
this pull request
Jun 29, 2015
This includes some major runtime performance improvements: facebook/regenerator#207 facebook/regenerator#208 And also some bug fixes relating to async generator functions: facebook/regenerator@29d81b6929 facebook/regenerator@7d2a052ddb facebook/regenerator@5b9dd1086d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete was causing deoptimization due to backing class change and was unnecessary as this field was explicitly initialized to undefined and was not being checked for existence as best I can tell.
When combined with #207 saw a 40x throughput improvement under FF, from 39k operations/sec to 1.6M ops/src on http://kpdecker.github.io/six-speed/