Skip to content

Commit

Permalink
@allow-large-files Upgrade xplat/js to Flow v0.66
Browse files Browse the repository at this point in the history
Reviewed By: gabelevi

Differential Revision: D7016717

fbshipit-source-id: 2bd2fd67074ba5d405ecd63a1aeb37354f8634c9
  • Loading branch information
Caleb Meredith authored and facebook-github-bot committed Feb 17, 2018
1 parent 49b8be1 commit 8c11832
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 9 deletions.
5 changes: 4 additions & 1 deletion .flowconfig
Expand Up @@ -8,8 +8,11 @@
<PROJECT_ROOT>/node_modules/react-static-container/node_modules/.*
<PROJECT_ROOT>/website-prototyping-tools/node_modules/.*
<PROJECT_ROOT>/website/node_modules/.*
; TODO: Update `iterall` to Flow 0.66
<PROJECT_ROOT>/node_modules/graphql/node_modules/iterall/.*

[libs]
flow
node_modules/fbjs/flow/lib

[options]
Expand All @@ -35,4 +38,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError

[version]
^0.65.0
^0.66.0
15 changes: 15 additions & 0 deletions flow/iterall.js
@@ -0,0 +1,15 @@
/**
* Copyright (c) 2013-present, Facebook, Inc.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
*/

'use strict';

// TODO: Update `iterall` to Flow 0.66
declare module 'iterall' {
declare module.exports: $FlowFixMe;
}
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -47,7 +47,7 @@
"fb-watchman": "^2.0.0",
"fbjs": "^0.8.14",
"fbjs-scripts": "0.7.1",
"flow-bin": "^0.65.0",
"flow-bin": "^0.66.0",
"graphql": "^0.13.1",
"gulp": "3.9.1",
"gulp-babel": "6.1.2",
Expand Down
3 changes: 0 additions & 3 deletions packages/react-relay/classic/store/RelayQueryWriter.js
Expand Up @@ -53,8 +53,6 @@ const {EXISTENT} = RelayClassicRecordState;
* Helper for writing the result of one or more queries/operations into the
* store, updating tracked queries, and recording changed record IDs.
*/
/* $FlowFixMe - Flow error detected during the deployment of v0.38.0. To see the
* error, remove this comment and run flow */
class RelayQueryWriter extends RelayQueryVisitor<WriterState> {
_changeTracker: RelayChangeTracker;
_forceIndex: number;
Expand Down Expand Up @@ -597,7 +595,6 @@ class RelayQueryWriter extends RelayQueryVisitor<WriterState> {
// Reuse existing generated IDs if the node does not have its own `id`.
const prevLinkedID = prevLinkedIDs && prevLinkedIDs[nextIndex];
const nextLinkedID = nextRecord[ID] || prevLinkedID || generateClientID();
// $FlowFixMe(>=0.33.0)
nextLinkedIDs.push(nextLinkedID);

// $FlowFixMe(>=0.33.0)
Expand Down
1 change: 0 additions & 1 deletion packages/react-relay/classic/store/RelayRecordStore.js
Expand Up @@ -282,7 +282,6 @@ class RelayRecordStore {
let connectionIDs;
forEachObject(record, (datum, key) => {
if (datum && getFieldNameFromKey(key) === schemaName) {
// $FlowFixMe: datum isn't guaranteed to be an object.
const connectionID = RelayRecord.getDataIDForObject(datum);
if (connectionID) {
connectionIDs = connectionIDs || [];
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Expand Up @@ -2141,9 +2141,9 @@ flat-cache@^1.2.1:
graceful-fs "^4.1.2"
write "^0.2.1"

flow-bin@^0.65.0:
version "0.65.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.65.0.tgz#64ffeca27211c786e2d68508c65686ba1b8a2169"
flow-bin@^0.66.0:
version "0.66.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.66.0.tgz#a96dde7015dc3343fd552a7b4963c02be705ca26"

for-each@~0.3.2:
version "0.3.2"
Expand Down

0 comments on commit 8c11832

Please sign in to comment.