Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax constraint of unique file names in Relay Modern #2093

Open
leebyron opened this issue Sep 11, 2017 · 5 comments
Open

Relax constraint of unique file names in Relay Modern #2093

leebyron opened this issue Sep 11, 2017 · 5 comments

Comments

@leebyron
Copy link
Contributor

Relay Classic / Compat require file names to match fragment names to ensure Relay Compat mechanisms work correctly. However in Relay Modern this doesn't necessarily need to be true.

There have been a few issues opened in the past about this issue, so it would be great to fix this with a pull request.

Note that fragment names should still continue to be unique across a compiled app.

@orlowang
Copy link

orlowang commented May 2, 2018

can relay-compiler support .jsx?

@josephsavona
Copy link
Contributor

For anyone interested in sending a PR, we are supportive of adding a config option (via relay-config) that allows an application to disable the document name validation.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 25, 2020
@LaylBongers
Copy link

This is still an issue currently, especially with frameworks like NextJS where module names for pages are used to determine their routing. This results in unhelpful name restrictions like:

  • src/pages/index.tsx -> pagesQuery
  • src/pages/items/[uuid].tsx -> uuidQuery

@stale stale bot removed the wontfix label Dec 10, 2021
@Mikoz93
Copy link

Mikoz93 commented Dec 12, 2021

And kebab-case naming convention #3081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants