Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax constraint of unique file names in Relay Modern #2109

Closed

Conversation

jkettmann
Copy link

See #2093

  • Allow fragment and operation names to be different from their modules names.
  • Ensure that all fragment and operation names are unique.

Only the Relay Modern part seems to be missing, as these changes are not specific for Relay Modern. This is why I only commented the constraining parts out.

How can we use these rules only on Relay Modern?

@jkettmann
Copy link
Author

@leebyron Might you have a look at this and tell me if this is the right direction? I could continue spending time on this and fix the failing flow checks then.

@alloy
Copy link
Contributor

alloy commented Jan 28, 2018

@leebyron bump

@laverneleah

This comment has been minimized.

@alloy
Copy link
Contributor

alloy commented Jan 28, 2018

@laverneleah You can unsubscribe yourself with the link you see in that email you got or by using the button here on this ticket with the button in the sidebar. It would also be nice if you could delete your comment here, the unnecessary noise it adds tot this thread does not help.

@jquense
Copy link
Contributor

jquense commented Jul 10, 2018

bump

@josephsavona
Copy link
Contributor

Thanks for submitting a PR. However, our focus with Relay Compiler is primarily on supporting Relay (Modern) runtime. Can you clarify how you'd actually take advantage of this? An alternative is to add a flag (via the new relay-config) that optionally disables the module-name-prefix requirement altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants