Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow types for 1.5 #2331

Closed
steida opened this issue Feb 20, 2018 · 2 comments
Closed

Flow types for 1.5 #2331

steida opened this issue Feb 20, 2018 · 2 comments

Comments

@steida
Copy link

steida commented Feb 20, 2018

I am confused. Is this libdefs official and ready for Relay 1.5 or not?

https://github.com/flowtype/flow-typed/tree/master/definitions/npm/react-relay_v1.x.x/flow_v0.47.x-

As for "Relay Containers are now properly Flow typed."

What does it mean? It's related to internal code or some Flow types should be used with createFragmentContainer etc.

Thank you for all your work!

@orta
Copy link
Contributor

orta commented Feb 21, 2018

It does look like this is just for internal code (otherwise I would have expected x.js.flow files in the pkg like how graphql-js does it )

Perhaps someone could try using the same technique as they used: graphql/graphql-js#412

@jstejada
Copy link
Contributor

sorry for the confusion @steida. I'm going to merge this into #2284 and clarify in the release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants