added polyfill message #1014
Closed
added polyfill message #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flow install seems to have some issues. |
|
|
||
| if (__DEV__) { | ||
| warning( | ||
| Promise && Array.prototype.find, |
There was a problem hiding this comment.
maybe change this to typeof Promise === 'function' to not throw if it's not defined.
(Or global.Promise, but I'm not sure that's working in all build systems?)
There was a problem hiding this comment.
I thought of doing global.Promise first but wasn't sure if it gets transformed correctly in browsers.
I'll go with the first. 👍
|
Thanks for doing this, just a small update please and we should be good to merge this. |
edvinerikson
force-pushed
the
add-polyfill-message
branch
from
86017b3
to
d140cf3
Compare
|
Awesome, I've updated the PR :) |
|
Thanks for the update! |
ghost
closed this
in
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #690
I couldn't really find more es6 stuff other than what it checks (except for
Mapwhich got transpiled to_Mapfor some reason).Not sure about tests.. Do we need a test for this and where should it go if so?
cc @josephsavona