Tweak QuickStart-Tutorial.zh-CN.md metadata for consistency #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this one like our other translations: - Use `.zh-CN` suffix instead of `-zh-CN`: this means that an appropriately configured web server can choose to serve up the right file based on the `Accept-Language` header. - Use same `id` as canonical version. We might end up changing our minds about that (see #1238), but in the meantime we should at least be consistent. I think we likely still have some issues here, so I'm going to keep poking around after this.
|
@facebook-github-bot import |
ghost
added
the
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this one like our other translations:
.zh-CNsuffix instead of-zh-CN: this means that an appropriately configured web server can choose to serve up the right file based on theAccept-Languageheader.idas canonical version. We might end up changing our minds about that (see Teach website sidebar to prefer en-US #1238), but in the meantime we should at least be consistent.I think we likely still have some issues here, so I'm going to keep poking around after this. Basically, I think at this point that we've unbroken our English docs and our Chinese docs are at least consistently defined, but the build process for the translations isn't producing a useful/accessible result.