Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2984 optimizing requestid #2985

Closed
wants to merge 3 commits into from
Closed

2984 optimizing requestid #2985

wants to merge 3 commits into from

Commits on Jan 6, 2020

  1. feat added requestID in compile time, refactor writeRelayGeneratedFile 

    Modified the compilation of the artifacts in order to generate a unique identifier (md5 text) for Request type nodes.

writeRelayGeneratedFile:

eliminate the switch, the node is always of type Request because inside 'if (generatedNode.kind === RelayConcreteNode.REQUEST) {'
https://github.com/facebook/relay/blob/master/packages/relay-compiler/codegen/writeRelayGeneratedFile.js#L98
    @morrys
    morrys committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    d86f8b5 View commit details
    Browse the repository at this point in the history

  2. adjusted getRequestIdentifier

    @morrys
    morrys committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    a80bcfa View commit details
    Browse the repository at this point in the history

  3. adjusted tests

    @morrys
    morrys committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    5913e75 View commit details
    Browse the repository at this point in the history