Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump immutable from 3.7.6 to 3.8.2 #3145

Conversation

DanielMSchmidt
Copy link

This changes the license of immutable to MIT. This is the changelog

@DanielMSchmidt DanielMSchmidt force-pushed the danielmschmidt/immutable-js-update branch from 3f81e78 to a2340f6 Compare August 3, 2020 14:44
@kassens
Copy link
Member

kassens commented Aug 7, 2020

Thanks for the PR!

I'll import this and see what happens.

If you're blocked by this, yarn has some way to override the modules so you can force recursive dependencies to update beyond the allowed range.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kassens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@DanielMSchmidt
Copy link
Author

@kassens I'm not really familiar with flow, could you help me troubleshoot the CI tests?

@kassens
Copy link
Member

kassens commented Aug 24, 2020

This turns out to be somewhat involved internally as we require not too many versions of third party libraries. Relay only uses immutable for the compiler and we'll somewhat soon replace that code so, I'm inclined to close this PR.

Good news for you is that shipped websites built with Relay don't need the immutable dependency for Relay.

@kassens kassens closed this Aug 24, 2020
@DanielMSchmidt DanielMSchmidt deleted the danielmschmidt/immutable-js-update branch August 27, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants