Fix version of the GraphQL.js version to 15.3.0 in babel-plugin-relay #3628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alunyov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goals here is to:
Make sure that the output of the parse/print in
babel-plugin-relayis matches the output we have in the rust version of the compiler. And I think in 15.3.0 it matches. This should resolve: Rust compiler: definition of 'XYZQuery' appears to have changed #3437With the release on new Rust based compiler we no longer need to include
graphql-jsas a peer dependency in therelay-compiler, so we can update our installation instructions and removegraphql-jsfrom there.Eventually, since we're only using parse/print functions from
graphql-jshere it is probably make sense to just inline them here.