[OSS v13 Compiler] Generate exact imports when using CommonJS and output #3675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old JS compiler would generate exact
foo$fragmentType
imports whenartifactDirectory
is set since this allows the compiler to know where all the artifacts would be (all in the same directory).The new compiler does not appear to support this currently. But this seemed easy enough to do, so I've taken a stab at it in this diff. I am not fluent in Rust (yet) so I am happy to take criticism on how to write this better!
Test plan:
cargo test
passescargo run --bin relay -- ../../../myproject/relay.config.json
produces the expected output.Example file diff from the rc0 version of the compiler to this PR/Diff: