Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse TypegenConfig for SingleProjectConfigFile #4585

Closed

Conversation

tobias-tengler
Copy link
Contributor

There are some slight discrepancies between multi- and single-project configs at the moment, with some options only being configurable from multi-project configs, even though the compiler could read and support the same settings from both type of configs (examples: use_import_type_syntax, require_custom_scalar_types, etc.).

Changes

  • Flatten TypegenConfig in SingleProjectConfigFile and remove duplicated options
  • Inlines no_future_proof_enums from FlowTypegenConfig into TypegenConfig and removes FlowTypegenConfig as it's now no longer required
  • When parsing of the config file fails, show the single-project config error first, since that is the configuration most people use

⚠️ Breaking change

This change is a breaking change, as the custom_scalars config option in the single-project config must now be specified as custom_scalar_types.

@tobias-tengler tobias-tengler changed the title Reuse TypegenConfig for SingleProjectFile Reuse TypegenConfig for SingleProjectConfigFile Jan 12, 2024
@facebook-github-bot
Copy link
Contributor

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@captbaritone merged this pull request in 4e68155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants