[relay-lsp] Support go to definition within schema (extension) files #4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
force-pushed
the
schema-document-lsp-support
branch
from
011cf3c
to
f49c0c9
Compare
tobias-tengler
commented
Feb 26, 2024
| @@ -516,8 +523,26 @@ impl<TPerfLogger: PerfLogger + 'static, TSchemaDocumentation: SchemaDocumentatio | |||
| js_server.process_js_source(uri, text); | |||
| } | |||
|
|
|||
| let source_location = SourceLocationKey::standalone(uri.path()); | |||
There was a problem hiding this comment.
Use FileCategorizer to determine whether the file is a schema (extension) file
| // First we check to see if this document has any GraphQL documents. | ||
| let embedded_sources = extract_graphql::extract(text); | ||
|
|
||
| let should_init_lsp_resources = | ||
| !embedded_sources.is_empty() || uri.as_str().ends_with(".graphql"); |
There was a problem hiding this comment.
Use FileCategorizer result here as well
| @@ -530,6 +555,13 @@ impl<TPerfLogger: PerfLogger + 'static, TSchemaDocumentation: SchemaDocumentatio | |||
| js_server.process_js_source(uri, full_text); | |||
| } | |||
|
|
|||
| let source_location = SourceLocationKey::standalone(uri.path()); | |||
| Ok(project_name.into()) | ||
| } | ||
|
|
||
| fn get_file_contents(path: &Path) -> LSPRuntimeResult<String> { |
| let file_path = uri | ||
| .to_file_path() | ||
| .map_err(|_| LSPRuntimeError::ExpectedError)?; | ||
| let text = get_file_contents(file_path.as_path())?; |
There was a problem hiding this comment.
Actually implement a TextSource without reading from disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4626