Integrate with Sapling or Git if they exist #4691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bigfootjon
added a commit
to bigfootjon/relay
that referenced
this pull request
May 7, 2024
Summary: When relay produces new files or deletes existing files, it will now automatically add them or remove them from source control (Sapling and Git are supported). Test Plan: I built the compiler locally and tested against a local Sapling repo. It worked as expected. I didn't have a chance to try it on a git repo though :/ Differential Revision: D56963384 Pulled By: bigfootjon
bigfootjon
force-pushed
the
source-control-integration
branch
from
a0e58ea
to
f98760b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56963384 |
Summary: When relay produces new files or deletes existing files, it will now automatically add them or remove them from source control (Sapling and Git are supported). Test Plan: I built the compiler locally and tested against a local Sapling repo. It worked as expected. Git support was checked by adding and removing some queries in: https://github.com/captbaritone/grats-relay-example Reviewed By: captbaritone Differential Revision: D56963384 Pulled By: bigfootjon
bigfootjon
force-pushed
the
source-control-integration
branch
from
f98760b
to
7c6a897
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56963384 |
|
@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@bigfootjon merged this pull request in 9cf21af. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some basic code here that is AFAICT only used in Meta's private version of the compiler. We can take that code, spruce it up a bit, and integrate it into the public version of the compiler!
Test plan:
I built the compiler locally and tested against a local Sapling repo. It worked as expected. I didn't have a chance to try it on a git repo though :/