Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to call javajni transaction.prepare() to implement 2pc #10283

Closed
jessin20161124 opened this issue Jun 30, 2022 · 4 comments
Closed

No way to call javajni transaction.prepare() to implement 2pc #10283

jessin20161124 opened this issue Jun 30, 2022 · 4 comments
Assignees

Comments

@jessin20161124
Copy link

jessin20161124 commented Jun 30, 2022

Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://groups.google.com/forum/#!forum/rocksdb or https://www.facebook.com/groups/rocksdb.dev

Expected behavior

No way to call javajni transaction.prepare() to implement 2pc

Actual behavior

Steps to reproduce the behavior

@jessin20161124 jessin20161124 changed the title No way to call javajni transaction.prepare() to implment 2pc No way to call javajni transaction.prepare() to implement 2pc Jun 30, 2022
@riversand963
Copy link
Contributor

I can see a prepare() function in Transaction java class: https://github.com/facebook/rocksdb/blob/main/java/src/main/java/org/rocksdb/Transaction.java#L181. Can you try it?

@riversand963 riversand963 added the waiting Waiting for a response from the issue creator. label Jul 19, 2022
@jessin20161124
Copy link
Author

I can see a prepare() function in Transaction java class: https://github.com/facebook/rocksdb/blob/main/java/src/main/java/org/rocksdb/Transaction.java#L181. Can you try it?

it is not a public method. I can not use it.

@riversand963
Copy link
Contributor

hmm, not sure if it's intentional, but commit() is public, and I think it can be made public.
Maybe @adamretter knows more.
Feel free to contribute a PR.

@adamretter
Copy link
Collaborator

@riversand963 @jessin20161124 I can try and take a look at that on Monday. If it is just a matter of exposing an API that in C++ is already public, we should be able to that in Java without much difficulty (cc @alanpaxton)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants