Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer builds with NIOSTATS_CONTEXT #10475

Closed
ronag opened this issue Aug 4, 2022 · 4 comments
Closed

No longer builds with NIOSTATS_CONTEXT #10475

ronag opened this issue Aug 4, 2022 · 4 comments
Assignees
Labels
Build build, makefile, cmake, scripts question

Comments

@ronag
Copy link

ronag commented Aug 4, 2022

../deps/rocksdb/rocksdb/logging/env_logger.h:60:7: error: use of undeclared identifier 'iostats_context'; did you mean 'get_iostats_context'?
      iostats_context.disable_iostats = true;
      ^~~~~~~~~~~~~~~
      get_iostats_context
../deps/rocksdb/rocksdb/include/rocksdb/iostats_context.h:95:17: note: 'get_iostats_context' declared here
IOStatsContext* get_iostats_context();
                ^
In file included from ../deps/rocksdb/rocksdb/env/env.cc:18:
../deps/rocksdb/rocksdb/logging/env_logger.h:60:22: error: member reference base type 'rocksdb::IOStatsContext *()' is not a structure or union
      iostats_context.disable_iostats = true;
      ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
../deps/rocksdb/rocksdb/logging/env_logger.h:65:7: error: use of undeclared identifier 'iostats_context'; did you mean 'get_iostats_context'?
      iostats_context.disable_iostats = false;
      ^~~~~~~~~~~~~~~
      get_iostats_context
../deps/rocksdb/rocksdb/include/rocksdb/iostats_context.h:95:17: note: 'get_iostats_context' declared here
IOStatsContext* get_iostats_context();
                ^
In file included from ../deps/rocksdb/rocksdb/env/env.cc:18:
../deps/rocksdb/rocksdb/logging/env_logger.h:65:22: error: member reference base type 'rocksdb::IOStatsContext *()' is not a structure or union
      iostats_context.disable_iostats = false;
@ronag
Copy link
Author

ronag commented Aug 4, 2022

Seems to be caused by cc20998

@ajkr ajkr added up-for-grabs Up for grabs Build build, makefile, cmake, scripts question labels Aug 4, 2022
@ronag
Copy link
Author

ronag commented Aug 7, 2022

@siying

@lhsoft
Copy link
Contributor

lhsoft commented Aug 9, 2022

@ajkr Please help to review: #10506 :)

@siying
Copy link
Contributor

siying commented Aug 9, 2022

Thanks for pointing it out, will fix.

@ajkr ajkr removed the up-for-grabs Up for grabs label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build build, makefile, cmake, scripts question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants