Fix no internal time recorded for small preclude_last_level #10829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
siying
approved these changes
Oct 20, 2022
|
|
||
| Options options = CurrentOptions(); | ||
| options.compaction_style = kCompactionStyleUniversal; | ||
| options.preclude_last_level_data_seconds = 60; |
There was a problem hiding this comment.
I know preserve_internal_time_seconds is 0 by default. But it might be better to set here too to make the test more explicit.
When the `preclude_last_level_data_seconds` or `preserve_internal_time_seconds` is smaller than 100 (seconds), no seqno->time information was recorded. Also make sure all data will be compacted to the last level even if there's no write to record the time information. Test Plan: added unittest
jay-zhuang
force-pushed
the
time_too_small
branch
from
1584bf2
to
f53abf9
Compare
|
@jay-zhuang has updated the pull request. You must reimport the pull request before landing. |
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 22, 2022
…0822) Summary: Allow the last level only compaction able to output result to penultimate level if the penultimate level is empty. Which will also block the other compaction output to the penultimate level. (it includes the PR #10829) Pull Request resolved: #10822 Reviewed By: siying Differential Revision: D40389180 Pulled By: jay-zhuang fbshipit-source-id: 4e5dcdce307795b5e07b5dd1fa29dd75bb093bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
preclude_last_level_data_secondsorpreserve_internal_time_secondsis smaller than 100 (seconds), no seqno->time information was recorded.Also make sure all data will be compacted to the last level even if there's no write to record the time information.
Test Plan: added unittest