clang-format cache/ and util/ directories #10867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is purely the result of running `clang-format -i` on files, except some files have been excluded for manual intervention in a separate PR Test Plan: `make check`, `make check-headers`, `make format`
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pdillinger
added a commit
to pdillinger/rocksdb
that referenced
this pull request
Oct 25, 2022
Summary: Complements facebook#10867 with some manual edits to avoid weird formatting or to avoid massive reformatting third party code. Test Plan: `make check` etc Reviewers: Subscribers: Tasks: Tags:
jay-zhuang
approved these changes
Oct 26, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
Summary: Complements #10867 with some manual edits to avoid weird formatting or to avoid massive reformatting third party code. Pull Request resolved: #10870 Test Plan: `make check` etc Reviewed By: riversand963 Differential Revision: D40686526 Pulled By: pdillinger fbshipit-source-id: 6af988fe4b0a8ae4a5992ec2c3c37fe67584226e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is purely the result of running
clang-format -ion files, except some files have been excluded for manual intervention in a separate PRTest Plan:
make check,make check-headers,make format