Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which version is the boundary between the two DeleteRange implementations ? #12692

Closed
guoxiangCN opened this issue May 23, 2024 · 3 comments
Closed

Comments

@guoxiangCN
Copy link

Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://groups.google.com/forum/#!forum/rocksdb or https://www.facebook.com/groups/rocksdb.dev

Expected behavior

N/A

Actual behavior

N/A

Steps to reproduce the behavior

N/A

Hi~
After reading the blog<<DeleteRange: A New Native RocksDB Operation>>, I learned that there are two implementations of DeleteRange in RocksDB, among which v1 is based on the Skyline algorithm, V2 is based on an algorithm that fragments range tombstones. I want to know,
Which version has made changes from v1 to v2? I want to understand the differences between the two by reading the source code~
Thank you everyone.

I am not a native English speaker, but I have translated these through translation apps. There may be grammar errors or offensive writing due to cultural differences. I apologize for any inconvenience caused!

@guoxiangCN
Copy link
Author

@ajkr

@ajkr
Copy link
Contributor

ajkr commented May 23, 2024

Hi, I would say v5.17.2 (https://github.com/facebook/rocksdb/tree/v5.17.2) was the latest version using the skyline implementation of DeleteRange().

Any release 5.18 or newer has the v2 implementation. It gradually improved over time so I'd just look at the latest code. By the way, every time I think about DeleteRange() v2, I first read this doc: https://github.com/cockroachdb/pebble/blob/e9edae8a5a90beba845b5dec543d5d78885f5d2a/docs/range_deletions.md. It has the step by step explanation of how we ended up in the current state for DeleteRange() v2.

@guoxiangCN
Copy link
Author

Thank you very much for your reply , it's very helpful to me! Wish you have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants