Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile does not install tools #1473

Open
alexreg opened this issue Nov 8, 2016 · 5 comments
Open

Makefile does not install tools #1473

alexreg opened this issue Nov 8, 2016 · 5 comments
Labels
up-for-grabs Up for grabs

Comments

@alexreg
Copy link

alexreg commented Nov 8, 2016

The tools are built, but install does not install them, nor is there a separate install-tools target.

@gfosco
Copy link
Contributor

gfosco commented Jan 10, 2018

Closing this via automation due to lack of activity. If discussion is still needed here, please re-open or create a new/updated issue.

@alexreg
Copy link
Author

alexreg commented Jan 10, 2018

Again, this is in your court! Please go investigate before closing. Not cool.

@gfosco
Copy link
Contributor

gfosco commented Jan 10, 2018

Responded in #1554

@ajkr
Copy link
Contributor

ajkr commented Jan 11, 2018

Thanks for reporting, I agree we should install at least ldb and sst_dump. Any others?

@ajkr ajkr reopened this Jan 11, 2018
@ajkr ajkr self-assigned this Jan 11, 2018
@alexreg
Copy link
Author

alexreg commented Jan 11, 2018

Thanks @ajkr, that would be great. I'll leave the choice of which binaries to you, but here's the relevant bit of the Mac Homebrew file for manually installing extra binaries, which you may be interested in:

    bin.install "sst_dump" => "rocksdb_sst_dump"
    bin.install "db_sanity_test" => "rocksdb_sanity_test"
    bin.install "db_stress" => "rocksdb_stress"
    bin.install "write_stress" => "rocksdb_write_stress"
    bin.install "ldb" => "rocksdb_ldb"
    bin.install "db_repl_stress" => "rocksdb_repl_stress"
    bin.install "rocksdb_dump"
    bin.install "rocksdb_undump"

This may be excessive though, I don't know. rocksdb_dump and rocksdb_undump certainly sound useful to have installed though.

@ramvadiv ramvadiv added the up-for-grabs Up for grabs label Sep 23, 2021
@ajkr ajkr removed their assignment Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up-for-grabs Up for grabs
Projects
None yet
Development

No branches or pull requests

4 participants