Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper use of ROCKSDB_SUPPORT_THREAD_LOCAL macro #2658

Closed
yuslepukhin opened this issue Jul 27, 2017 · 0 comments
Closed

Improper use of ROCKSDB_SUPPORT_THREAD_LOCAL macro #2658

yuslepukhin opened this issue Jul 27, 2017 · 0 comments

Comments

@yuslepukhin
Copy link
Contributor

The macro is defined to be either 0 or 1 but always defined

However, the code, even in the same file, makes different use of it.
For some placed it is #ifdef ROCKSDB_SUPPORT_THREAD_LOCAL which is always true
and yet for other is #if !(ROCKSDB_SUPPORT_THREAD_LOCAL)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuslepukhin