Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading options from map mentions wrong options #6065

Open
kwek20 opened this issue Nov 21, 2019 · 0 comments
Open

Loading options from map mentions wrong options #6065

kwek20 opened this issue Nov 21, 2019 · 0 comments

Comments

@kwek20
Copy link
Contributor

kwek20 commented Nov 21, 2019

Expected behavior

When i load a map with config values, and one of those has a typo/unknown key, RocksDB lets me know there is something wrong with the map in a more meaningful manner.

Example: DBOptions found unexpected key: "avoid_unecesary_blocking_io" (typo)
Or, a parameter which will be filled with an error message, or DBOptions.printErrors(). Anything :D

If you have a lot of options, it makes it hard to find the culprit

Actual behavior

DBOptions returns null instead of a DBOptions object

Steps to reproduce the behavior

for Java:

// my file contains a typo on one line, but all other options are correct
Map<String, Properties> map = loadDBOptionsFromMyFileSomewhere();
DBOptions options = DBOptions.getDBOptionsFromProps(map.get("DBOptions"));

if (options == null){
    System.out.println("Failed loading DBOptions")
}
@kwek20 kwek20 changed the title ignore_unknown_options mention wrong options Loading options from map mentions wrong options Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant