Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skew between DBOptions and ImmutableDBOptions #6677

Open
mrambacher opened this issue Apr 9, 2020 · 0 comments
Open

Skew between DBOptions and ImmutableDBOptions #6677

mrambacher opened this issue Apr 9, 2020 · 0 comments
Assignees

Comments

@mrambacher
Copy link
Contributor

Prior to #6552 , the ImmutableDBOptions and DBOptions had a one-to-one value correspondence. Every value that was in ImmutableDBOptions was also in DBOptions.

To simplify the API, the std::shared_ptr fs value was deleted from the DBOptions but it was not removed from ImmutableDBOptions.

This means that there is now a divergence between these two structures.

Since #6552, you also cannot create an ImmutableDBOptions with a DBOptions that has a NULL env (it will SEGV). All DBOptions must be sanitized prior to making them Immutable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants