Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmake support for ROCKSDB_LITE #7213

Open
ajkr opened this issue Jul 31, 2020 · 0 comments
Open

fix cmake support for ROCKSDB_LITE #7213

ajkr opened this issue Jul 31, 2020 · 0 comments
Labels
up-for-grabs Up for grabs

Comments

@ajkr
Copy link
Contributor

ajkr commented Jul 31, 2020

Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://groups.google.com/forum/#!forum/rocksdb or https://www.facebook.com/groups/rocksdb.dev

Expected behavior

When setting ROCKSDB_LITE=On in cmake, the compiler should be passed one -O flag (probably -Os?) regardless of the CMAKE_BUILD_TYPE.

Actual behavior

Multiple -O flags may be passed, while only the last one takes effect. This results in unpredictable behavior.

Steps to reproduce the behavior

$ cmake .. -DCMAKE_BUILD_TYPE=Release -DROCKSDB_LITE=On && make -j48 VERBOSE=1 db_bench
...
[  2%] Building CXX object CMakeFiles/rocksdb-shared.dir/cache/cache.cc.o
/bin/c++  ... -Os -O2 ...
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up-for-grabs Up for grabs
Projects
None yet
Development

No branches or pull requests

1 participant