Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Retryable and DataLoss errors, EventListener::OnBackgroundError status is not set on the way in or checked on the way out #7503

Open
mrambacher opened this issue Oct 3, 2020 · 0 comments
Labels
bug Confirmed RocksDB bugs

Comments

@mrambacher
Copy link
Contributor

This was found by code inspection.

According to the documentation, the "bg_error" status is called with a non-OK status and the callback can set this to an "OK" value to suppress the error. By code inspection, it appears that it is always called with an OK status (s is not set to the new error) and that status is never checked or used as part of the return status (s is not checked for).

Expected behavior

Actual behavior

Steps to reproduce the behavior

The error_handler_fs_test shows calls to this handler passing in OK even when the underlyin Status is not OK.

@mrambacher mrambacher added the bug Confirmed RocksDB bugs label Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed RocksDB bugs
Projects
None yet
Development

No branches or pull requests

1 participant