Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MultiRead return status #7510

Open
anand1976 opened this issue Oct 6, 2020 · 1 comment
Open

Handle MultiRead return status #7510

anand1976 opened this issue Oct 6, 2020 · 1 comment
Labels
up-for-grabs Up for grabs

Comments

@anand1976
Copy link
Contributor

Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://groups.google.com/forum/#!forum/rocksdb or https://www.facebook.com/groups/rocksdb.dev

Expected behavior

In BlockBasedTable::RetrieveMultipleBlocks, the return status of the MultiRead call should be handled - https://github.com/facebook/rocksdb/blob/master/table/block_based/block_based_table_reader.cc#L1696. In case of error, the error status should be reflected in each of the read requests.

Actual behavior

The return status is ignored.

Steps to reproduce the behavior

Read the code.

@anand1976 anand1976 added the up-for-grabs Up for grabs label Oct 6, 2020
@jagij
Copy link

jagij commented Oct 19, 2020

Master has been updated in the mean time. This link should work:

file->MultiRead(opts, &read_reqs[0], read_reqs.size(), &direct_io_buf)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up-for-grabs Up for grabs
Projects
None yet
Development

No branches or pull requests

2 participants