Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary Instance should pass read_only=true #8193

Closed
jay-zhuang opened this issue Apr 15, 2021 · 1 comment
Closed

Secondary Instance should pass read_only=true #8193

jay-zhuang opened this issue Apr 15, 2021 · 1 comment
Assignees

Comments

@jay-zhuang
Copy link
Contributor

Quote @ajkr https://github.com/facebook/rocksdb/pull/8171/files#r612195411:

I think DBImpl should be passed read_only=true. That's a new flag introduced in #8142 to prevent SanitizeOptions() from creating an info logger when none is provided (i.e., info_log == nullptr). I'd guess in a secondary DB, a SanitizeOptions()-created info logger could conflict with the primary DB info logger. It looks like OpenAsSecondary() tries to avoid opening the DB with option info_log == nullptr -- except when L616 is executed.

@jay-zhuang
Copy link
Contributor Author

jay-zhuang commented Apr 15, 2021

Seems minor issue, included it in #8171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant