[RFC] Move RADOS support to separate repo #9206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riversand963
added
the
rocksdb-7.0
ajkr
approved these changes
Nov 24, 2021
PLUGINS.md
Outdated
| @@ -2,3 +2,4 @@ This is the list of all known third-party plugins for RocksDB. If something is m | |||
|
|
|||
| * [Dedupfs](https://github.com/ajkr/dedupfs): an example for plugin developers to reference | |||
| * [ZenFS](https://github.com/westerndigitalcorporation/zenfs): a file system for zoned block devices | |||
| * [RADOS](https://github.com/riversand963/rocksdb-hdfs-env): an Env used for interacting with RADOS. Migrated from RocksDB main repo. | |||
There was a problem hiding this comment.
Can you double check the URL? The RADOS item has "rocksdb-hdfs-env" in it.
riversand963
force-pushed
the
rados-as-plugin
branch
from
2a95bd2
to
7aa48e9
Compare
|
Thanks @ajkr for the review! |
riversand963
added a commit
to riversand963/rocksdb
that referenced
this pull request
Dec 1, 2021
Summary: Not a CMake expert, and the current CMake build support added by this PR is unlikely the best way of doing it. Sending out the PR to demonstrate it can work. Test Plan: Will need to update https://github.com/ajkr/dedupfs with CMake build. Also, PR facebook#9170 and PR facebook#9206 both include CMake support for their plugins, and can be used as a proof of concept.
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 1, 2021
Summary: Not a CMake expert, and the current CMake build support added by this PR is unlikely the best way of doing it. Sending out the PR to demonstrate it can work. Pull Request resolved: #9214 Test Plan: Will need to update https://github.com/ajkr/dedupfs with CMake build. Also, PR #9170 and PR #9206 both include CMake support for their plugins, and can be used as a proof of concept. Reviewed By: ajkr Differential Revision: D32738273 Pulled By: riversand963 fbshipit-source-id: da87fb4377c716bbbd577a69763b48d22483f845
riversand963
force-pushed
the
rados-as-plugin
branch
from
7aa48e9
to
d2e279c
Compare
riversand963
changed the title
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
riversand963
force-pushed
the
rados-as-plugin
branch
from
d2e279c
to
e0f1e7e
Compare
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ljflores
added a commit
to ljflores/ceph
that referenced
this pull request
Jul 6, 2023
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
14 tasks
ljflores
added a commit
to ljflores/ceph
that referenced
this pull request
Jul 12, 2023
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com> (cherry picked from commit 2fca433)
joscollin
pushed a commit
to joscollin/ceph
that referenced
this pull request
Jul 31, 2023
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
aaSharma14
pushed a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Sep 25, 2023
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
aaSharma14
pushed a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Oct 11, 2023
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
aaSharma14
pushed a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Jan 2, 2024
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves RADOS support from RocksDB repo to a separate repo. The new (temporary?) repo
in this PR serves as an example before we finalize the decision on where and who to host RADOS support. At this point,
people can start from the example repo and fork.
The goal is to include this commit in RocksDB 7.0 release.
Reference:
https://github.com/ajkr/dedupfs by @ajkr
Test plan:
Follow instructions in https://github.com/riversand963/rocksdb-rados-env/blob/main/README.md and build
test binary
env_librados_testand run it.Also, make check