Skip to content

Commit

Permalink
Remove sapling_fbclone cargo setup
Browse files Browse the repository at this point in the history
Summary:
Autocargo should only be used where necessary for some business need
(like OSS).

See https://fb.workplace.com/groups/rust.language/posts/25399030776385531

`fbclone` is not synced to github. The rust version is only built for
Windows and that's done with buck:

https://www.internalfb.com/code/fbsource/[7607fe9950ff]/fbcode/eden/scm/fb/packaging/build_nupkg.py?lines=548-550

The `setup.py` reference looks like leftover from when `fbclone` was
switched to building with buck (D50704305) from cargo (D28299741).

Reviewed By: sggutier

Differential Revision: D51674043

fbshipit-source-id: 0cedd4db2132bbcf39cbf820a898a4e12fa24444
  • Loading branch information
zertosh authored and facebook-github-bot committed Nov 29, 2023
1 parent d9d4604 commit 56ec1cd
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions eden/scm/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -1235,10 +1235,6 @@ def build_libraries(self, libraries):
RustBinary("scm_daemon", manifest="exec/scm_daemon/Cargo.toml"),
]

if havefb and iswindows and not skip_other_binaries:
rustextbinaries += [RustBinary("fbclone", manifest="fb/fbclone/Cargo.toml")]


if sys.platform == "cygwin":
print("WARNING: CYGWIN BUILD NO LONGER OFFICIALLY SUPPORTED")

Expand Down

0 comments on commit 56ec1cd

Please sign in to comment.