recoil: remove usage in isl

Summary: Kill the rest of `import 'recoil'` logic. Reviewed By: evangrayk Differential Revision: D53784065 fbshipit-source-id: 10166697e580868e29d760e3163f65fc7f53a338
facebook · Feb 15, 2024 · e932310 · e932310
1 parent 7b403fc
commit e932310
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 445 deletions.
diff --git a/addons/isl/package.json b/addons/isl/package.json
@@ -21,7 +21,6 @@
     "jotai": "^2.6.2",
     "react": "^18.1.0",
     "react-dom": "^18.1.0",
-    "recoil": "^0.7.5",
     "shared": "0.1.0",
     "typescript": "^4.4.2",
     "vite": "^5.1.0-beta.2",

diff --git a/addons/isl/src/AccessGlobalRecoil.tsx b/addons/isl/src/AccessGlobalRecoil.tsx
diff --git a/addons/isl/src/App.tsx b/addons/isl/src/App.tsx
@@ -9,7 +9,6 @@ import type {RepositoryError} from './types';
 import type {ReactNode} from 'react';
 import type {Writable} from 'shared/typeUtils';
 
-import {AccessGlobalRecoil} from './AccessGlobalRecoil';
 import {CommandHistoryAndProgress} from './CommandHistoryAndProgress';
 import {CommitInfoSidebar} from './CommitInfoView/CommitInfoView';
 import {CommitTreeList} from './CommitTreeList';
@@ -31,7 +30,6 @@ import {GettingStartedModal} from './gettingStarted/GettingStartedModal';
 import {I18nSupport, t, T} from './i18n';
 import {setJotaiStore} from './jotaiUtils';
 import platform from './platform';
-import {getEntangledAtomsInitializedState} from './recoilUtils';
 import {DEFAULT_RESET_CSS} from './resetStyle';
 import {useMainContentWidth, zoomUISettingAtom} from './responsive';
 import {applicationinfo, repositoryInfo} from './serverAPIState';
@@ -44,7 +42,6 @@ import * as stylex from '@stylexjs/stylex';
 import {VSCodeButton} from '@vscode/webview-ui-toolkit/react';
 import {Provider, useAtom, useAtomValue, useSetAtom, useStore} from 'jotai';
 import React from 'react';
-import {RecoilRoot} from 'recoil';
 import {ContextMenus} from 'shared/ContextMenu';
 import {Icon} from 'shared/Icon';
 import {useThrottledEffect} from 'shared/hooks';
@@ -57,22 +54,19 @@ export default function App() {
       <ResetStyle />
       <I18nSupport>
         <MaybeWithJotaiRoot>
-          <RecoilRoot initializeState={getEntangledAtomsInitializedState}>
-            <AccessGlobalRecoil />
-            <ISLRoot>
-              <ISLCommandContext>
-                <ErrorBoundary>
-                  <ISLDrawers />
-                  <TooltipRootContainer />
-                  <GettingStartedModal />
-                  <ComparisonViewModal />
-                  <ModalContainer />
-                  <ContextMenus />
-                  <TopLevelToast />
-                </ErrorBoundary>
-              </ISLCommandContext>
-            </ISLRoot>
-          </RecoilRoot>
+          <ISLRoot>
+            <ISLCommandContext>
+              <ErrorBoundary>
+                <ISLDrawers />
+                <TooltipRootContainer />
+                <GettingStartedModal />
+                <ComparisonViewModal />
+                <ModalContainer />
+                <ContextMenus />
+                <TopLevelToast />
+              </ErrorBoundary>
+            </ISLCommandContext>
+          </ISLRoot>
         </MaybeWithJotaiRoot>
       </I18nSupport>
     </React.StrictMode>

diff --git a/addons/isl/src/__tests__/AccessGlobalRecoil.test.tsx b/addons/isl/src/__tests__/AccessGlobalRecoil.test.tsx