Quick fix for #89: Bump pyre-extensions version in requirements.txt #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump pyre-extensions version in requirements.txt Since, these are extensions are for the typing module, I think we can remove the version information as well. Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
facebook-github-bot
added
the
CLA Signed
|
@stroxler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
stroxler
approved these changes
Mar 6, 2023
| @@ -9,7 +9,7 @@ ipython<8.4.0 | |||
| munch==2.5.0 | |||
| prompt-toolkit==3.0.29 | |||
| Pygments==2.12.0 | |||
| pyre-extensions==0.0.27 | |||
| pyre-extensions==0.0.30 | |||
There was a problem hiding this comment.
Thanks for the fix, looks good to me!
I'll try to get this landed today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump pyre-extensions version in requirements.txt
Since, these are extensions are for the typing module, I think we can remove the version information as well.
Pre-submission checklist
black .usort format .flake8pip install -r requirements-dev.txtand completed the following:./scripts/run-tests.shand made sure all tests are passingSummary
A simple version bump for pyre-extensions.
In order to prevent dependency issues in sapp, we decided to pin versions in the requirements.txt. Now a package that pyre-check introduces a dependency conflict as it depends on a newer version of a package (pyre-extensions)
Bumping pyre-extensions which extend the typing module. Since it is non-breaking module (pyre-extensions), we could potentially unpin the versioning information and allow pyre-check to dictate the version. However, I could be wrong here.
Test Plan
The frontend tests are failing however, but I strongly believe them to be un-related to this PR.
Fixes #89