Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of makefile... #4

Closed
fenrus75 opened this issue May 5, 2015 · 8 comments
Closed

Lack of makefile... #4

fenrus75 opened this issue May 5, 2015 · 8 comments

Comments

@fenrus75
Copy link

fenrus75 commented May 5, 2015

There doesn't seem to be any sign of any makefile or related infrastructure....

@fredemmott
Copy link
Contributor

This was released in an incomplete state so that it could be used by HHVM 3.6; it's fairly simple to build, and you can see how HHVM builds it here:

https://github.com/hhvm/hhvm-third-party/blob/master/squangle/CMakeLists.txt

The main thing you'd be likely to want to change is to not build a static library.

I'm trying to get this project owned as a standalone project instead of just a dependency, and this is definitely a priority once that happens.

@fenrus75
Copy link
Author

fenrus75 commented May 5, 2015

well yeah we're trying to package HHVM for our distro, and the released
tarfile of it has no copy of squangle...
hence wanting to package this one ;-)

On Tue, May 5, 2015 at 8:42 AM, Fred Emmott notifications@github.com
wrote:

This was released in an incomplete state so that it could be used by HHVM
3.6; it's fairly simple to build, and you can see how HHVM builds it here:

https://github.com/hhvm/hhvm-third-party/blob/master/squangle/CMakeLists.txt

The main thing you'd be likely to want to change is to not build a static
library.

I'm trying to get this project owned as a standalone project instead of
just a dependency, and this is definitely a priority once that happens.


Reply to this email directly or view it on GitHub
#4 (comment).

@fredemmott
Copy link
Contributor

We don't make tarballs - and unfortunately github's automatic ones don't include submodules :(

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@fredemmott
Copy link
Contributor

no thanks FBBot.

@respu
Copy link

respu commented Aug 9, 2015

Any updates on this ?

@SharpMan
Copy link

They won't they don't care. They are just saying 'Hi we have a mysql async client library !'
especially when this quality of code https://github.com/facebook/squangle/blob/master/squangle/mysql_client/Query.cpp#L236
doesn't need to go in production

@fredemmott
Copy link
Contributor

Closing all issues and moving to facebookarchive; this is still supported as a dependency of HHVM, but not as a standalone project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants