fix: add treeshakeCompensation to esbuild plugin
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Thanks for the quick fix to documentation, but could you instead setting |
|
@nmn will add. thanks for letting me know 👍 |
nedjulius
changed the title
tsconfig setup info to esbuild-plugin docstreeshakeCompensation to esbuild plugin
|
updated the PR |
2 tasks
nmn
requested changes
Feb 21, 2024
| @@ -115,6 +115,7 @@ export default function stylexPlugin({ | |||
| jsxSyntaxPlugin, | |||
| stylexBabelPlugin.withOptions({ | |||
| ...options, | |||
| treeshakeCompensation: true, | |||
There was a problem hiding this comment.
Ideally, you should make treeshakeCompensation an optional argument that defaults to true.
There was a problem hiding this comment.
I think moving it above ...options should suffice?
nmn
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
This PR adds
treeshakeCompensation: trueto stylex babel plugin in esbuild plugin to avoid elision of modules. It also adds an esbuild plugin test case forTypeScriptfiles.Linked PR/Issues
Fixes #454
Pre-flight checklist
Contribution Guidelines