Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark open-props type as module for ESM compat #525

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Apr 8, 2024

Fixes #505

Marks the @stylexjs/open-props package as an ESM package.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.52 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.04 (3.22) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.48 (3.75) 0.00 (0.00) 0.0% (0.0%)

Copy link

github-actions bot commented Apr 8, 2024

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1128.74 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.32 (10185.35) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 123.42 (774.34) 0.00 (0.00) 0.0% (0.0%)

@eryue0220
Copy link

Sorry, I didn't notice this PR before. I committed a related pr, but the solution is different with this one. I think this will affect those non esm modules.

@nmn
Copy link
Contributor Author

nmn commented Apr 9, 2024

@eryue0220 I saw your PR as well. I've been thinking about it and I don't think the extra work you did is needed. Since open-props needs to be compiled when used, it's not necessary to make CJS packages available at all.

@eryue0220
Copy link

@nmn Sorry for the late response. I thought you are right, and I've closed my pr. Thank you for your answer.

@nmn nmn merged commit b52c3c3 into main Apr 11, 2024
9 checks passed
@nmn nmn deleted the fix/open-props-esm branch April 11, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@styles/open-props]: Has any plan/progress to support ESM?
3 participants