fix: usage of styles in a loop and non-existent styles #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
compressed-size: runtime library Size change: 0.00 kB View unchanged
|
|
compressed-size: e2e bundles Size change: 0.00 kB View unchanged
|
necolas
reviewed
Apr 9, 2024
| import stylex from '@stylexjs/stylex'; | ||
| function test(colors, obj) { | ||
| for (const color of colors) { | ||
| obj[color.key] = stylex(color.style); |
There was a problem hiding this comment.
Is there already a test for this against the stylex.props syntax?
There was a problem hiding this comment.
I'll add it. For now I was testing the specific code that caused a breakage.
There was a problem hiding this comment.
OK, it's worth testing everything against the main syntax first. Tests against the legacy syntax are only relevant for Meta.
nmn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found and fixed a bug in the optimisation step for optimising
stylex.props()andstylex()calls within afor-ofloop.The custom
evaluatelogic would fail to bail out and throw a null pointer exception instead.The fix was to check for that null value and bail out instead.
Also, internally there are some rare example of non-existent styles (
styles.unknown) being used which can cause the Babel plugin to throw an error.Added a check to bail out instead of throwing an error for such cases and added a couple of test cases to verify that the fix works for
stylex(),stylex.props()andstylex.attrs().