Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add babel-plugin-syntax-hermes-parser dependency to esbuild plugin #579

Conversation

nedjulius
Copy link
Contributor

What changed / motivation ?

Adds missing babel-plugin-syntax-hermes-parser dependency to esbuild plugin.

Linked PR/Issues

Fixes #576

Additional Context

Screenshots, Tests, Anything Else

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2024
@nmn nmn merged commit 758b4c4 into facebook:main May 22, 2024
9 checks passed
@nmn
Copy link
Contributor

nmn commented May 22, 2024

Thanks!

@nedjulius nedjulius deleted the nedjulius/fix-missing-hermes-plugin-dependency-esbuild-plugin branch May 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esbuild plugin has undeclared dependency on babel-plugin-syntax-hermes-parser
3 participants