Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass caller to babel within rollup plugin #612

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Jun 23, 2024

Fixes #402

There has been reports of the Rollup Plugin not playing well with babel-env. A fix was suggested in the issue above which is what this PR implements.

Still trying to reproduce the bug, but putting up this PR in the meantime for review.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2024
Copy link

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.52 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.04 (3.22) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.48 (3.75) 0.00 (0.00) 0.0% (0.0%)

Copy link

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1128.74 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.32 (10185.35) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 123.42 (774.34) 0.00 (0.00) 0.0% (0.0%)

@nmn
Copy link
Contributor Author

nmn commented Jun 23, 2024

I can't reproduce the issue, but the change doesn't cause any regression either.

@nmn nmn merged commit 35df29f into main Jun 23, 2024
9 checks passed
@nmn nmn deleted the fix/rollup-issues branch June 23, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Babel plugin is not compatible with @babel/preset-env
2 participants