Calculate time on remote end #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of timezone (not time) difference between source and destination we can end up with invalid testing time. Touch command takes [[CC]YY]MMDDhhmm[.ss], which if calculated locally might end up being in the past on remote end (since there is no timezone information). This fixes it by passing timestamp and calculating time on remote end.
jaymzh
requested changes
Nov 2, 2016
| transport.run! | ||
| end | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def touchcmd | ||
| touch = Base64.encode64("touch --date \"$(date -d @" + |
There was a problem hiding this comment.
This doesn't work on macs:
[root@mactest989.06.ash3 ~]# date -d @1478049513 +'%Y-%m-%d %T'
usage: date [-jnu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ...
[-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]
There was a problem hiding this comment.
Nor does your touch command:
[root@mactest989.06.ash3 ~]# touch --date
touch: illegal option -- -
usage:
touch [-A [-][[hh]mm]SS] [-acfhm] [-r file] [-t [[CC]YY]MMDDhhmm[.SS]] file ...
|
@jaymzh works on Darwin now |
jaymzh
requested changes
Nov 7, 2016
| "#{TasteTester::Config.testing_end_time.to_i} +'%Y%m%d%H%M.%S')\"" + | ||
| " #{TasteTester::Config.timestamp_file}; else touch --date \"$(date -d @" + | ||
| "#{TasteTester::Config.testing_end_time.to_i} +'%Y-%m-%d %T')\"" + | ||
| " #{TasteTester::Config.timestamp_file}; fi").delete("\n") |
There was a problem hiding this comment.
no, this needs to be contiguous string with no newlines, which Base64.encode64 sprinkles all over
jaymzh
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of timezone (not time) difference between source and destination we can end up with invalid testing time. Touch command takes [[CC]YY]MMDDhhmm[.ss], which if calculated locally might end up being in the past on remote end (since there is no timezone information).
This fixes it by passing timestamp and calculating time on remote end.