Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to specify a different knife config. #83

Merged
merged 1 commit into from Nov 17, 2017
Merged

Allow user to specify a different knife config. #83

merged 1 commit into from Nov 17, 2017

Conversation

jaymzh
Copy link
Collaborator

@jaymzh jaymzh commented Nov 17, 2017

This is useful when using taste-tester for separate environments.

NaomiReeves
NaomiReeves reviewed Nov 17, 2017
View reviewed changes
Copy link
Contributor

@NaomiReeves NaomiReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code seems sane, but want to clean up the rubocop violations while you're updating?

@jaymzh
Allow user to specify a different knife config.
e2e384f 
This is useful when using taste-tester for separate environments.
NaomiReeves
NaomiReeves approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@NaomiReeves NaomiReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm

@jaymzh jaymzh mentioned this pull request Nov 17, 2017
Closed
@jaymzh jaymzh merged commit 6db27d4 into facebook:master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaomiReeves NaomiReeves NaomiReeves approved these changes

@davide125 davide125 Awaiting requested review from davide125

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaymzh @NaomiReeves @facebook-github-bot