Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type validation for mock_constructor #141

Closed
fornellas opened this issue Apr 6, 2020 · 1 comment · Fixed by #146
Closed

Add type validation for mock_constructor #141

fornellas opened this issue Apr 6, 2020 · 1 comment · Fixed by #146
Assignees
@fornellas
Labels
enhancement New feature or request
Milestone
Type Checking

Comments

@fornellas
Copy link
Contributor

Currently there's no type checking for mock_constructor, let's add it, and include 2 tests at least:

  • Fails with wrong type.
  • Passes with wrong type and type_validation=False.
@fornellas fornellas added enhancement New feature or request help wanted Extra attention is needed labels Apr 6, 2020
@fornellas fornellas added this to the Type Checking milestone Apr 6, 2020
@fornellas
Copy link
Contributor Author

Draft on this branch.

@fornellas fornellas self-assigned this Apr 7, 2020
@fornellas fornellas removed the help wanted Extra attention is needed label Apr 7, 2020
@fornellas fornellas mentioned this issue Apr 8, 2020
Closed
@fornellas fornellas linked a pull request Apr 8, 2020 that will close this issue
Add type validation to mock constructor #146
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fornellas fornellas

Labels
enhancement New feature or request
Projects
None yet
Milestone
Type Checking
Development

Successfully merging a pull request may close this issue.

Add type validation to mock constructor facebook/TestSlide
1 participant
@fornellas