go to holdover if best GM is worse than 10us (#326)

Summary: Pull Request resolved: #326 We should not allow selection of the GM which has a bad clock quality. It's better to just switch to holdover Reviewed By: vvfedorenko Differential Revision: D53310144 fbshipit-source-id: 8025da97b253884358c8dcb1e98c7ac4159a6c2a
facebook · Feb 1, 2024 · 1996517 · 1996517
1 parent 0db5072
commit 1996517
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/ptp/sptp/client/bmca.go b/ptp/sptp/client/bmca.go
@@ -36,7 +36,8 @@ func bmca(msgs []*ptp.Announce, prios map[ptp.ClockIdentity]int) *ptp.Announce {
 			best = b
 		}
 	}
-	if best.AnnounceBody.GrandmasterClockQuality.ClockClass >= ptp.ClockClass13 {
+	// Never select GM in worse than holdover status or with clock quality worse than 10 microseconds
+	if best.AnnounceBody.GrandmasterClockQuality.ClockClass > ptp.ClockClass7 || best.AnnounceBody.GrandmasterClockQuality.ClockAccuracy > ptp.ClockAccuracyMicrosecond10 {
 		return nil
 	}
 	return best

diff --git a/ptp/sptp/client/bmca_test.go b/ptp/sptp/client/bmca_test.go
@@ -37,8 +37,15 @@ func TestBmcaProperlyUsesLocalPriority(t *testing.T) {
 }
 
 func TestBmcaNoMasterForCalibrating(t *testing.T) {
-	best := ptp.Announce{AnnounceBody: ptp.AnnounceBody{GrandmasterIdentity: 1, GrandmasterClockQuality: ptp.ClockQuality{ClockClass: ptp.ClockClass52}}}
-	worse := ptp.Announce{AnnounceBody: ptp.AnnounceBody{GrandmasterIdentity: 2, GrandmasterClockQuality: ptp.ClockQuality{ClockClass: ptp.ClockClass13}}}
+	best := ptp.Announce{AnnounceBody: ptp.AnnounceBody{GrandmasterIdentity: 1, GrandmasterClockQuality: ptp.ClockQuality{ClockClass: ptp.ClockClass13}}}
+	worse := ptp.Announce{AnnounceBody: ptp.AnnounceBody{GrandmasterIdentity: 2, GrandmasterClockQuality: ptp.ClockQuality{ClockClass: ptp.ClockClass52}}}
+	selected := bmca([]*ptp.Announce{&best, &worse}, map[ptp.ClockIdentity]int{1: 2, 2: 1})
+	require.Empty(t, selected)
+}
+
+func TestBmcaNoMasterForLowAccuracy(t *testing.T) {
+	best := ptp.Announce{AnnounceBody: ptp.AnnounceBody{GrandmasterIdentity: 1, GrandmasterClockQuality: ptp.ClockQuality{ClockAccuracy: ptp.ClockAccuracyMicrosecond100}}}
+	worse := ptp.Announce{AnnounceBody: ptp.AnnounceBody{GrandmasterIdentity: 2, GrandmasterClockQuality: ptp.ClockQuality{ClockAccuracy: ptp.ClockAccuracySecond10}}}
 	selected := bmca([]*ptp.Announce{&best, &worse}, map[ptp.ClockIdentity]int{1: 2, 2: 1})
 	require.Empty(t, selected)
 }