Skip to content

Commit

Permalink
win: add --return-nonzero-on-failures to sc_testpilot
Browse files Browse the repository at this point in the history
Summary:
For whatever reason, sc_testpilot default to --return-zero-on-failures, which
means that test failures are simply not reported properly to the signal box.
Fix that by explicitely passing --return-nonzero-on-failures

Reviewed By: fanzeyi

Differential Revision: D29509158

fbshipit-source-id: ef991f91df48e99769f96ffd8d7015cdf507c723
  • Loading branch information
xavierd authored and facebook-github-bot committed Jul 1, 2021
1 parent f78d4f9 commit 5535a29
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions build/fbcode_builder/getdeps/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,7 @@ def list_tests():
"--test-config",
"platform=%s" % machine_suffix,
"buildsystem=getdeps",
"--return-nonzero-on-failures",
]
else:
testpilot_args = [
Expand Down

0 comments on commit 5535a29

Please sign in to comment.