Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchman-wait uses dict.iteritems() for python3 #660

Open
fragmuffin opened this issue Dec 11, 2018 · 2 comments
Open

watchman-wait uses dict.iteritems() for python3 #660

fragmuffin opened this issue Dec 11, 2018 · 2 comments

Comments

@fragmuffin
Copy link

fragmuffin commented Dec 11, 2018

I've installed v4.9.0 from source onto ubuntu distro' and I'm getting the following error when using python3.5

$ watchman-wait . -p '*.py'
Traceback (most recent call last):
  File "/usr/local/bin/watchman-wait", line 185, in <module>
    for _, sub in subscriptions.iteritems():
AttributeError: 'dict' object has no attribute 'iteritems'

$ head -n 1 $(which watchman-wait)
#!/usr/bin/python3

$ /usr/bin/python3 --version
Python 3.5.2

Similar to: Homebrew/homebrew-core#33227

Steps to Reproduce
I created this gist to build the fault into a docker image.

docker build runs the following setup.sh:

#!/usr/bin/env bash

apt-get update

# watchman
#   variation of: https://facebook.github.io/watchman/docs/install.html#installing-from-source
apt-get install libssl-dev autoconf automake libtool pkg-config wget \
    python3.5 python3.5-dev python3-pip -y
ln -s /usr/bin/python3.5 /usr/bin/python3

watchman_ver=4.9.0
pushd /tmp
wget -nv https://github.com/facebook/watchman/archive/v${watchman_ver}.tar.gz \
    -O watchman-${watchman_ver}.tar.gz
tar -xzf watchman-${watchman_ver}.tar.gz
cd watchman-${watchman_ver}
./autogen.sh
./configure
make
make install
popd

# pip upgrade
python3 -m pip install --upgrade pip
fragmuffin added a commit to cqparts/cqparts_webapi that referenced this issue Dec 23, 2018
@jsamr
Copy link

jsamr commented Mar 25, 2020

Still occurring to me on Archlinux.

@saveman71
Copy link

saveman71 commented Apr 1, 2020

Same here, seems like this is resurfacing. Reported to the arch bug tracker here: https://bugs.archlinux.org/task/66057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants