Queries serialization improvements #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irakliyk
force-pushed
the
queries-deserialization
branch
from
fa7ce54
to
0eefbd1
Compare
kchalkias
approved these changes
May 4, 2021
| assert!(!query_values.is_empty(), "query values cannot be empty"); | ||
| let elements_per_query = query_values[0].len(); | ||
| assert!( | ||
| elements_per_query != 0, |
There was a problem hiding this comment.
I usually do too - but in this case we need to cache the elements_per_query value - so, I think it's OK to have it like this.
| /// TODO: return values as a vector of field elements | ||
| pub fn into_batch<H: Hasher>(self, num_leaves: usize) -> (BatchMerkleProof, Vec<Vec<u8>>) { | ||
| /// Convert a set of queries into a batch Merkle proof and corresponding query values. | ||
| pub fn deserialize<H: Hasher, E: FieldElement>( |
There was a problem hiding this comment.
Can any zero value or length cause issues or panic (ie division by zero?)
There was a problem hiding this comment.
Good point! I've added some assertions here as this code gets called internally from within Winterfell. So, if it is called with wrong parameters, it's ok to panic.
Jasleen1
pushed a commit
to Jasleen1/winterfell
that referenced
this pull request
Sep 8, 2021
Rescue hash example
Jasleen1
pushed a commit
to Jasleen1/winterfell
that referenced
this pull request
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #6 and also improves queries serialization/deserialization overall. Specifically:
The overall impact of this PR is ~1% reduction in proof sizes, but it also lays groundwork for switching over to new Merkle tree implementation.