Explicitly only support 1 auxiliary segment #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irakliyk
requested changes
Apr 2, 2024
…aux_segment_num_rand_elements()
irakliyk
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Looks good! Thank you! I left a coupe of minor comments inline. After these are addressed, we can merge.
There is also a bigger comment about renaming. Currently we use main_segment and main_trace as well as aux_segment and aux_trace somewhat interchangeably. I think we should just use main_trace and aux_trace everywhere. But this renaming should probably be done in another PR.
irakliyk
approved these changes
Apr 3, 2024
irakliyk
pushed a commit
that referenced
this pull request
May 9, 2024
irakliyk
pushed a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the half-support for multiple auxiliary segment. We now explicitly support only one.