Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f64: additional conversions #268

Merged
merged 1 commit into from
Mar 29, 2024
Merged

f64: additional conversions #268

merged 1 commit into from
Mar 29, 2024

Conversation

hackaugusto
Copy link
Contributor

This adds the following conversions to the 64 bit field:

  • impl From<bool> for BaseElement
  • TryFrom<BaseElement> for u32
  • TryFrom<BaseElement> for u16
  • TryFrom<BaseElement> for u8
  • TryFrom<BaseElement> for bool

irakliyk
irakliyk approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I'll merge it into the main branch and will make a patch release.

@irakliyk irakliyk changed the base branch from next to main March 29, 2024 00:41
@irakliyk irakliyk changed the base branch from main to next March 29, 2024 00:41
@irakliyk irakliyk merged commit e34e6a1 into facebook:next Mar 29, 2024
9 checks passed
irakliyk pushed a commit that referenced this pull request Mar 29, 2024
@hackaugusto @irakliyk
f64: additional conversions (#268)
39f6317
@hackaugusto hackaugusto deleted the hacka-f64-conversions branch March 29, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hackaugusto @irakliyk @facebook-github-bot