-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AsyncProver
#275
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing as we will go in a different direction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #271.
Introduced an asynchronous version of
Prover
(under a new"async"
feature). A few notes:impl Trait
in traits of Rust 1.75. I chose not to use theasync
syntactic sugar, as it doesn't allow us to specify+ Send + Sync
on the returnFuture
s (as explained in the linked blog post).trait-variant
crate, but thetrait_variant
macro didn't like ourE: FieldElement<BaseField = Self::BaseField>
bound ingenerate_proof()
(with a difficult to decipher error message).+ Send
bounds. So I decided to only support the+ Send + Sync
variant, so that it would work withtokio
'sspawn()
.tracing
spans in a few spots if we decide to go down this routeProver::generate_proof()
into many sub- functions, and call the appropriate ones inAsyncProver::generate_proof()
so as to remove the amount of copy/paste code"async"
featureI'm happy to revisit any of these assumptions 🙂.